[
https://issues.apache.org/jira/browse/PHOENIX-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236825#comment-17236825
]
ASF GitHub Bot commented on PHOENIX-6187:
-----------------------------------------
stoty commented on pull request #921:
URL: https://github.com/apache/phoenix/pull/921#issuecomment-731657197
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 38s | master passed |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 8s | phoenix-core in master has 966 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 12s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| -1 :x: | checkstyle | 0m 46s | phoenix-core: The patch generated 23
new + 887 unchanged - 5 fixed = 910 total (was 892) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 22s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 162m 7s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate
ASF License warnings. |
| | | 201m 32s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-921/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/921 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 719fb8347180 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f1a0860 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-921/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-921/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-921/1/testReport/
|
| Max. process+thread count | 6156 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-921/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid swallowing UPSERT... ON DUPLICATION KEY UPDATE failures
> --------------------------------------------------------------
>
> Key: PHOENIX-6187
> URL: https://issues.apache.org/jira/browse/PHOENIX-6187
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Mehdi Salarkia
> Assignee: Mehdi Salarkia
> Priority: Critical
>
> When there is an UPSERT with an ON DUPLICATE KEY condition, if the region
> mutation response is a failure it gets ignore and silently swallowed
> resulting in silent write failures.
> This is a major issue resulting in client assuming the write was successful
> while it actually was not.
> Also see another report
> [https://lists.apache.org/thread.html/ra229cea951236d9c48d06ec137f415997f0acb0d99078a6c19290c0e%40%3Cdev.phoenix.apache.org%3E]
> Which could be cause by this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
