[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238327#comment-17238327
]
ASF GitHub Bot commented on PHOENIX-5872:
-----------------------------------------
stoty commented on pull request #775:
URL: https://github.com/apache/phoenix/pull/775#issuecomment-733180362
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 33s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 2m 21s | master passed |
| +1 :green_heart: | javadoc | 0m 47s | master passed |
| +0 :ok: | spotbugs | 2m 52s | phoenix-core in master has 966 extant
spotbugs warnings. |
| -0 :warning: | patch | 2m 59s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 1m 1s | root in the patch failed. |
| -1 :x: | compile | 0m 50s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 50s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 2m 26s | phoenix-core: The patch generated 64
new + 4559 unchanged - 15 fixed = 4623 total (was 4574) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
| -1 :x: | spotbugs | 0m 49s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 46s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate
ASF License warnings. |
| | | 32m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/775 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux ebb1d6da4dc2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f1f92aa |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/testReport/
|
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Close Internal Phoenix Connections that were running during cancel
> ------------------------------------------------------------------
>
> Key: PHOENIX-5872
> URL: https://issues.apache.org/jira/browse/PHOENIX-5872
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.3, 4.x
> Reporter: Daniel Wong
> Assignee: Daniel Wong
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5872.4.x.patch, PHOENIX-5872v2.4.x.patch,
> PHOENIX-5872v3.4.x.patch, PHOENIX-5872v3.master.patch,
> PHOENIX-5872v4.4.x.patch, PHOENIX-5872v5.4.x.patch
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> 3 part approach:
> 1 don't count internal phoenix connections toward the client limit.
> 2 count internal phoenix connections toward a newly defined limit
> 3 track parent and child relationships between connections to close those
> connections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
