[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238614#comment-17238614
]
ASF GitHub Bot commented on PHOENIX-5592:
-----------------------------------------
stoty commented on pull request #975:
URL: https://github.com/apache/phoenix/pull/975#issuecomment-733568019
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 26s | 4.x passed |
| +1 :green_heart: | compile | 1m 10s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 53s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 53s | 4.x passed |
| +0 :ok: | spotbugs | 3m 55s | phoenix-core in 4.x has 950 extant
spotbugs warnings. |
| -0 :warning: | patch | 4m 3s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 31s | the patch passed |
| +1 :green_heart: | compile | 1m 11s | the patch passed |
| +1 :green_heart: | javac | 1m 11s | the patch passed |
| -1 :x: | checkstyle | 1m 1s | phoenix-core: The patch generated 526
new + 1110 unchanged - 5 fixed = 1636 total (was 1115) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| -1 :x: | spotbugs | 4m 10s | phoenix-core generated 7 new + 950
unchanged - 0 fixed = 957 total (was 950) |
||| _ Other Tests _ |
| -1 :x: | unit | 215m 47s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate
ASF License warnings. |
| | | 255m 58s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in
org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection,
ViewInfoTracker, Configuration, Mapper$Context) At
PhoenixTTLDeleteJobMapper.java:then immediately reboxed in
org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection,
ViewInfoTracker, Configuration, Mapper$Context) At
PhoenixTTLDeleteJobMapper.java:[line 146] |
| | Boxing/unboxing to parse a primitive
org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[]) At
PhoenixTTLTool.java:org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[])
At PhoenixTTLTool.java:[line 115] |
| | Possible null pointer dereference of cmdLine in
org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception
path Dereferenced at PhoenixTTLTool.java:cmdLine in
org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception
path Dereferenced at PhoenixTTLTool.java:[line 184] |
| | Integral value cast to double and then passed to Math.ceil in
org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List,
Configuration) At DefaultMultiViewSplitStrategy.java:and then passed to
Math.ceil in
org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List,
Configuration) At DefaultMultiViewSplitStrategy.java:[line 39] |
| | Exception is caught when Exception is not thrown in
org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration)
At DefaultPhoenixMultiViewListProvider.java:is not thrown in
org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration)
At DefaultPhoenixMultiViewListProvider.java:[line 141] |
| | Boxing/unboxing to parse a primitive
org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration)
At
PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration)
At PhoenixConfigurationUtil.java:[line 451] |
| | Boxing/unboxing to parse a primitive
org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration)
At
PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration)
At PhoenixConfigurationUtil.java:[line 481] |
| Failed junit tests | TEST-[GroupByIT_0] |
| | TEST-[IntArithmeticIT_0] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/975 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux e553143007c3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / c3818ee |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/testReport/
|
| Max. process+thread count | 5977 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MapReduce job to asynchronously delete rows where the VIEW_TTL has expired.
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-5592
> URL: https://issues.apache.org/jira/browse/PHOENIX-5592
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Major
> Fix For: 4.16.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Find the entities from the system catalog which views have TTLs defined on
> them. Spawn an MR job, whose splitter will create a map task. The mapper
> issues “select count(1) from the entity and Inject TTL attributes and Delete
> Hint during Map task. Since the current Phoniex MR framework doesn't support
> this feature, PhoenixMultiViewReader, PhoenixMultiViewInputSplit,
> PhoenixMultiViewInputFormat, and a few MR related util classes need to
> implement.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
