virajjasani commented on a change in pull request #982:
URL: https://github.com/apache/phoenix/pull/982#discussion_r530918621
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java
##########
@@ -269,4 +317,49 @@ public void
testInvalidConnUpdateCacheFrequencyShouldThrow() throws Exception {
}
}
}
+
+ /**
+ * Helper Runnable impl class that continuously keeps checking
+ * if SYSTEM.MUTEX contains any record until either interrupted or
+ * provided connection is closed
+ */
+ private static class SystemMutexCaller implements Runnable {
Review comment:
@ChinmaySKulkarni We can use `DelegateConnectionQueryServices` and
override `writeMutexCell()`, sounds good, but I still feel from completeness of
IT test viewpoint, current one (threads scanning SYSTEM.MUTEX with specific
rowkey) could be better test. Thought?
Moreover, it is also confirmed that this same test fails 100% of times
without source changes in this PR. Tested in multiple runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
