virajjasani commented on pull request #990: URL: https://github.com/apache/phoenix/pull/990#issuecomment-737036166
Thanks for the review @stoty > Does the plan involve removing the existing line-by-line generation and building the String format plan form the new object at some point ? Indeed I think we can give this a shot in long term for sure. That's also partly the reason why I have kept separate new API which takes object builder as input rather than updating current API which just takes list of String to accumulate entire plan step by step. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
