[
https://issues.apache.org/jira/browse/PHOENIX-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245457#comment-17245457
]
ASF GitHub Bot commented on PHOENIX-5787:
-----------------------------------------
stoty commented on pull request #42:
URL: https://github.com/apache/phoenix-connectors/pull/42#issuecomment-740117174
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 9m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 54s | master passed |
| +1 :green_heart: | compile | 2m 35s | master passed |
| +1 :green_heart: | checkstyle | 0m 21s | master passed |
| -1 :x: | javadoc | 0m 14s | phoenix5-connectors-assembly in master
failed. |
| +0 :ok: | spotbugs | 5m 15s | root in master has 116 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 1m 40s | phoenix-hive-base in master has 46
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 48s | phoenix-hive-base/phoenix4-hive in
master has 46 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 56s | phoenix-hive-base/phoenix5-hive in
master has 45 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 16m 44s | the patch passed |
| +1 :green_heart: | compile | 3m 8s | the patch passed |
| +1 :green_heart: | javac | 3m 8s | the patch passed |
| -1 :x: | checkstyle | 0m 29s | root: The patch generated 103 new + 0
unchanged - 0 fixed = 103 total (was 0) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 7s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | yamllint | 0m 2s | There were no new yamllint
issues. |
| -1 :x: | javadoc | 1m 4s | root generated 6 new + 14 unchanged - 6
fixed = 20 total (was 20) |
| +1 :green_heart: | spotbugs | 10m 26s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 55m 50s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate
ASF License warnings. |
| | | 127m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/42 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml
compile spotbugs hbaseanti checkstyle |
| uname | Linux ef4e9831bd02 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 234ed7c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/artifact/yetus-general-check/output/branch-javadoc-phoenix5-connectors-assembly.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/testReport/
|
| Max. process+thread count | 1635 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base phoenix-hive-base/phoenix4-hive
phoenix-hive-base/phoenix5-hive phoenix5-connectors-assembly . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-42/7/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Do not package hive dependencies into phoenix-hive jar
> ------------------------------------------------------
>
> Key: PHOENIX-5787
> URL: https://issues.apache.org/jira/browse/PHOENIX-5787
> Project: Phoenix
> Issue Type: Bug
> Components: connectors, hive-connector
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Phoenix and hive share a lot of dependencies, starting with hadoop and hbase.
> We are shading all phoenix dependencies into the phoenix-hive connector, that
> regularly case classpath/version mismatch problems with hive.
> Instead of trying to resolve these one by one, exclude/shade all dependencies
> from phoenix-jar that are available on the hive classpath.
> The most critcal of these are the hadoop and hbase transitive dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
