gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r539742976



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -1034,6 +1066,15 @@ private void 
removeBatchMutateContext(ObserverContext<RegionCoprocessorEnvironme
       this.batchMutateContext.remove();
   }
 
+    @Override
+    public void preWALAppend(ObserverContext<RegionCoprocessorEnvironment> c, 
WALKey key,
+                             WALEdit edit) {
+        if (HbaseCompatCapabilities.hasPreWALAppend() && shouldWALAppend) {

Review comment:
       Despite the name, IndexRegionObserver is actually the coproc that lives 
on _base tables_, not indexes. (GlobalIndexChecker is the index coproc)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to