[
https://issues.apache.org/jira/browse/PHOENIX-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247579#comment-17247579
]
ASF GitHub Bot commented on PHOENIX-6118:
-----------------------------------------
stoty commented on pull request #878:
URL: https://github.com/apache/phoenix/pull/878#issuecomment-742885157
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
9 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 53s | 4.x passed |
| +1 :green_heart: | compile | 0m 31s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 32s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 17s | 4.x passed |
| +0 :ok: | spotbugs | 0m 50s | phoenix-pherf in 4.x has 42 extant
spotbugs warnings. |
| -0 :warning: | patch | 0m 57s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 29s | the patch passed |
| +1 :green_heart: | compile | 0m 29s | the patch passed |
| -1 :x: | javac | 0m 29s | phoenix-pherf generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) |
| -1 :x: | checkstyle | 0m 48s | phoenix-pherf: The patch generated 682
new + 822 unchanged - 57 fixed = 1504 total (was 879) |
| -1 :x: | whitespace | 0m 0s | The patch 12 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 7s | The patch has no ill-formed XML
file. |
| -1 :x: | javadoc | 0m 16s | phoenix-pherf generated 31 new + 32
unchanged - 0 fixed = 63 total (was 32) |
| -1 :x: | spotbugs | 1m 4s | phoenix-pherf generated 9 new + 41
unchanged - 1 fixed = 50 total (was 42) |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 52s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate
ASF License warnings. |
| | | 27m 57s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-pherf |
| | Found reliance on default encoding in
org.apache.phoenix.pherf.util.PhoenixUtil.buildStatement(RulesApplier,
Scenario, List, PreparedStatement, SimpleDateFormat):in
org.apache.phoenix.pherf.util.PhoenixUtil.buildStatement(RulesApplier,
Scenario, List, PreparedStatement, SimpleDateFormat): String.getBytes() At
PhoenixUtil.java:[line 557] |
| | Should
org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$NoopTenantOperationImpl
be a _static_ inner class? At TenantOperationFactory.java:inner class? At
TenantOperationFactory.java:[lines 461-464] |
| | Dead store to tableName in
org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$PreScenarioTenantOperationImpl$1.apply(TenantOperationInfo)
At
TenantOperationFactory.java:org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$PreScenarioTenantOperationImpl$1.apply(TenantOperationInfo)
At TenantOperationFactory.java:[line 434] |
| | input must be non-null but is marked as nullable At
TenantOperationFactory.java:is marked as nullable At
TenantOperationFactory.java:[lines 279-329] |
| |
org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$QueryTenantOperationImpl$1.apply(TenantOperationInfo)
may fail to clean up java.sql.Statement on checked exception Obligation to
clean up resource created at TenantOperationFactory.java:up java.sql.Statement
on checked exception Obligation to clean up resource created at
TenantOperationFactory.java:[line 305] is not discharged |
| | input must be non-null but is marked as nullable At
TenantOperationFactory.java:is marked as nullable At
TenantOperationFactory.java:[lines 342-421] |
| |
org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$UpsertTenantOperationImpl$1.apply(TenantOperationInfo)
may fail to clean up java.sql.Statement Obligation to clean up resource
created at TenantOperationFactory.java:up java.sql.Statement Obligation to
clean up resource created at TenantOperationFactory.java:[line 367] is not
discharged |
| | Should
org.apache.phoenix.pherf.workload.mt.tenantoperation.TenantOperationFactory$UserDefinedOperationImpl
be a _static_ inner class? At TenantOperationFactory.java:inner class? At
TenantOperationFactory.java:[lines 486-489] |
| | Return value of TenantOperationFactory.getPhoenixUtil() ignored, but
method has no side effect At TenantOperationWorkHandler.java:but method has no
side effect At TenantOperationWorkHandler.java:[line 52] |
| Failed junit tests | phoenix.pherf.PherfTest |
| | phoenix.pherf.ResourceTest |
| | phoenix.pherf.RuleGeneratorTest |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/878 |
| JIRA Issue | PHOENIX-6118 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle |
| uname | Linux 19a3f8c4f3a8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / a3b6d0b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/diff-compile-javac-phoenix-pherf.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/testReport/
|
| Max. process+thread count | 102 (vs. ulimit of 30000) |
| modules | C: phoenix-pherf U: phoenix-pherf |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-878/4/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Multi Tenant Workloads using PHERF
> ----------------------------------
>
> Key: PHOENIX-6118
> URL: https://issues.apache.org/jira/browse/PHOENIX-6118
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Jacob Isaac
> Assignee: Jacob Isaac
> Priority: Major
> Fix For: 4.16.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Features like PHOENIX_TTL and Splittable SYSCAT need to be tested for a large
> number of tenant views.
> In the absence of support for creating a large number of tenant views - Multi
> leveled views dynamically and be able to query them in a generic framework,
> the teams have to write custom logic to replay/run functional and perf
> testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
