richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743126134
> Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? No, it is not. hbase-common is requireed only for the phoenix5 as we import org.apache.hadoop.hbase.TableName; there but in phoenix 4 it is not imported. maven-dependency-plugin:analyze-only marked it as an unused dependency in some of the earlier iterations. I think it did not run earlier on that module so we did not notice it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
