[ 
https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247842#comment-17247842
 ] 

ASF GitHub Bot commented on PHOENIX-6261:
-----------------------------------------

richardantal commented on pull request #44:
URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743126134


   > Nice cleanup, one question: `hbase-common` is not required as `provided` 
dependency for `phoenix-connectors-phoenix4-compat`?
   
   No, it is not. hbase-common is requireed only for the phoenix5 as we import 
org.apache.hadoop.hbase.TableName; there but in phoenix 4 it is not imported.
   maven-dependency-plugin:analyze-only marked it as an unused dependency in 
some of the earlier iterations. 
   I think it did not run earlier on that module so we did not notice it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Reorganise project structure to make mvn versions:set work
> ----------------------------------------------------------
>
>                 Key: PHOENIX-6261
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6261
>             Project: Phoenix
>          Issue Type: Task
>          Components: connectors, core
>            Reporter: Richard Antal
>            Assignee: Richard Antal
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to