[
https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247941#comment-17247941
]
ASF GitHub Bot commented on PHOENIX-6253:
-----------------------------------------
stoty commented on pull request #45:
URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743213150
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 17m 19s | master passed |
| +1 :green_heart: | compile | 2m 15s | master passed |
| +1 :green_heart: | javadoc | 2m 20s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 17m 2s | the patch passed |
| +1 :green_heart: | compile | 2m 23s | the patch passed |
| +1 :green_heart: | javac | 2m 23s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 29s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 10m 17s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate
ASF License warnings. |
| | | 67m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/45 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 8acdac3e4279 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / aff86a2 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/whitespace-eol.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/testReport/
|
| Max. process+thread count | 1707 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base phoenix-pig-base phoenix-kafka-base
phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly .
U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change shaded connector jar naming convention
> ---------------------------------------------
>
> Key: PHOENIX-6253
> URL: https://issues.apache.org/jira/browse/PHOENIX-6253
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Currently we distinguish the shaded and unshaded connector JARs by moving the
> version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while
> phoenix5-6.0.0-hive.jar is the shaded one.
> This is unintuitive, and we have already dropped this convention in core.
> We could use something like:
> -phoenix5-spark-6.0.0.jar: the unshaded connector JAR-
> -phoenix5-spark-connector-6.0.0.jar : the default shaded connector JAR-
> -phoenix5-spark-connector-byo-hbase-6.0.0.jar : alternative shaded connector
> JAR.-
> phoenix5-spark-6.0.0.jar: the unshaded connector JAR
> phoenix5-spark-6.0.0-shaded.jar : the default shaded connector JAR
> phoenix5-spark-6.0.0-shaded-byo-hbase.jar : alternative shaded connector JAR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
