[
https://issues.apache.org/jira/browse/PHOENIX-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249245#comment-17249245
]
Geoffrey Jacoby commented on PHOENIX-6058:
------------------------------------------
Tests should pass on all supported versions on each branch (1.3, 1.4, 1.5, 1.6
for 4.x and 2.1, 2.2, and 2.3 for master).
In some cases if a test just exercises a feature that doesn't exist for a given
HBase branch, it should use
Assume.assumeTrue(HbaseCompatCapabilities.someVersionSpecificFlag) to be
ignored where not supported
In other cases, where the presence or absence of a feature changes the correct
answer of a test, the test should use an appropriate flag to control its
assertions.
Looks like the latter is what the master addendum does, so +1
> When maxLookback is not enabled, IndexTool should not do deep verification
> --------------------------------------------------------------------------
>
> Key: PHOENIX-6058
> URL: https://issues.apache.org/jira/browse/PHOENIX-6058
> Project: Phoenix
> Issue Type: Bug
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6058.4.x.001.patch, PHOENIX-6058.4.x.002.patch,
> PHOENIX-6058.master.001.patch
>
>
> IndexTool does two types of verification, verifying the latest row versions,
> and verifying all row versions within the maxLookback windows. Verifying just
> the latest version can be called shallow verification whereas verifying all
> versions can be called deep verification. The maxLookback feature preserves
> all row versions including delete markers within the maxLookback window. This
> allows IndexTool to compare all versions of data rows with all versions of
> the index rows within the window. However, due to a bug, when the maxLookback
> feature is not enabled, i.e., the maxLookback window is set to zero,
> IndexTool assumes the window size is infinite and thus does deep
> verification. Since some versions of the index rows can be removed by
> compaction independently if the maxLookback feature is not enabled, IndexTool
> may report missing or invalid index rows by doing deep verification.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
