jpisaac commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r544507112
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java
##########
@@ -204,17 +213,22 @@ public
PhoenixTTLRegionScanner(RegionCoprocessorEnvironment env, Scan scan,
private boolean doNext(List<Cell> result, boolean raw) throws
IOException {
try {
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
boolean hasMore;
do {
hasMore = raw ? scanner.nextRaw(result) :
scanner.next(result);
if (result.isEmpty()) {
break;
}
+ if (isDummy(result)) {
+ return true;
+ }
numRowsScanned++;
if (maskIfExpired && checkRowNotExpired(result)) {
break;
}
+ //TODO 6211 The following logic does not sound correct
Review comment:
@gjacoby126 @kadirozde if this comment was related to the test failures,
then as I indicated we have a fix for it. The test failures were happening when
deleting from local indexes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
