[
https://issues.apache.org/jira/browse/PHOENIX-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250867#comment-17250867
]
ASF GitHub Bot commented on PHOENIX-6267:
-----------------------------------------
stoty commented on pull request #1021:
URL: https://github.com/apache/phoenix/pull/1021#issuecomment-747271138
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 28s | master passed |
| +1 :green_heart: | compile | 0m 53s | master passed |
| +1 :green_heart: | checkstyle | 0m 51s | master passed |
| +1 :green_heart: | javadoc | 0m 43s | master passed |
| +0 :ok: | spotbugs | 2m 57s | phoenix-core in master has 972 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 31s | the patch passed |
| +1 :green_heart: | compile | 0m 52s | the patch passed |
| +1 :green_heart: | javac | 0m 52s | the patch passed |
| -1 :x: | checkstyle | 0m 51s | phoenix-core: The patch generated 8
new + 851 unchanged - 8 fixed = 859 total (was 859) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 5s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 107m 31s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 28s | The patch generated 1 ASF License
warnings. |
| | | 144m 14s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1021 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 7a7dda56e543 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 6e019dd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 6712 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1021/3/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> View Index PK Fixed Width Field Truncation
> -------------------------------------------
>
> Key: PHOENIX-6267
> URL: https://issues.apache.org/jira/browse/PHOENIX-6267
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Geoffrey Jacoby
> Assignee: Gokcen Iskender
> Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6267.4.x.001.patch,
> PHOENIX-6267.master.001.patch, PHOENIX-6267.master.002.patch,
> PHOENIX-6267.master.003.patch
>
>
> 1. Create a table T
> 2. Create a view V that extends the PK of T, where the last field of the
> view's PK is a fixed width column C such as an INTEGER or BIGINT
> 3. Create a view index VI on V that does NOT contain C in its index key
> 4. Select C from the view with a query that runs against the view index
> You will get the following error:
> {code:java}
> java.sql.SQLException: ERROR 201 (22000): Illegal data. Expected length of
> at least 8 bytes, but had 7
> {code}
> [~giskender], [~kadir], [~tkhurana] and I investigated. It appears the
> problem comes from
> IndexMaintainer.buildRowKey:707-713
> {code:java}
> int length = stream.size();
> int minLength = length - maxTrailingNulls;
> byte[] indexRowKey = stream.getBuffer();
> // Remove trailing nulls
> while (length > minLength && indexRowKey[length-1] ==
> QueryConstants.SEPARATOR_BYTE) {
> length--;
> }
> {code}
> The logic to remove trailing separator bytes shouldn't run if the end of the
> index key (i.e the end of the base PK) is a fixed width column. Otherwise,
> we'll truncate whenever the last byte of the fixed width field happens to be
> \x00
>
> This only happens for view indexes (mutitenant or not)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
