[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253242#comment-17253242
]
ASF GitHub Bot commented on PHOENIX-5435:
-----------------------------------------
stoty commented on pull request #1030:
URL: https://github.com/apache/phoenix/pull/1030#issuecomment-749314328
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
3 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 57s | master passed |
| +1 :green_heart: | compile | 1m 17s | master passed |
| +1 :green_heart: | checkstyle | 10m 2s | master passed |
| +1 :green_heart: | javadoc | 2m 29s | master passed |
| +0 :ok: | spotbugs | 0m 30s | phoenix-hbase-compat-2.3.0 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 26s | phoenix-hbase-compat-2.2.1 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 28s | phoenix-hbase-compat-2.1.6 in master
has 1 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 972 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 42s | root in master has 1021 extant spotbugs
warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 24s | the patch passed |
| +1 :green_heart: | compile | 1m 15s | the patch passed |
| +1 :green_heart: | cc | 1m 15s | the patch passed |
| +1 :green_heart: | javac | 1m 15s | the patch passed |
| -1 :x: | checkstyle | 10m 21s | root: The patch generated 552 new +
22558 unchanged - 232 fixed = 23110 total (was 22790) |
| +1 :green_heart: | prototool | 0m 2s | There were no new prototool
issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 2m 28s | the patch passed |
| -1 :x: | spotbugs | 3m 10s | phoenix-core generated 1 new + 972
unchanged - 0 fixed = 973 total (was 972) |
| -1 :x: | spotbugs | 4m 6s | root generated 1 new + 1021 unchanged -
0 fixed = 1022 total (was 1021) |
||| _ Other Tests _ |
| -1 :x: | unit | 106m 27s | root in the patch failed. |
| -1 :x: | asflicense | 1m 53s | The patch generated 1 ASF License
warnings. |
| | | 185m 54s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES
is a mutable array At MetaDataEndpointImpl.java: At
MetaDataEndpointImpl.java:[line 343] |
| FindBugs | module:root |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES
is a mutable array At MetaDataEndpointImpl.java: At
MetaDataEndpointImpl.java:[line 343] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux 5d600763565e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 1dcb749 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 6852 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-2.3.0 phoenix-hbase-compat-2.2.1
phoenix-hbase-compat-2.1.6 phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Annotate HBase WALs with Phoenix Metadata
> -----------------------------------------
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple <tenant_id, table-or-view-name, timestamp>, or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
