[
https://issues.apache.org/jira/browse/PHOENIX-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256164#comment-17256164
]
Istvan Toth commented on PHOENIX-6104:
--------------------------------------
First of all, my previous complaints about not being able to split the table
anywhere were wrong, I didn't read the code carefully enough.
The exceptions are in fact originating from
org.apache.hadoop.hbase.regionserver.ConstantSizeRegionSplitPolicy.shouldSplit():
{code:java}
// If any of the stores are unable to split (eg they contain reference
files)
// then don't split
if ((!store.canSplit())) {
return false;
}
{code}
So your above patch is the correct fix, as it waits until all daughter regions
have come online after each split, and avoids trying to split the regions that
are not completely done yet.
The only minor problem is that testing for online status doesn't seem to be
correct, as an online doesn't seem to be necessarily splittable (the 10 second
sleep before the test seems to be there to compensate for this.)
Please review my modified PR, which checks for _isSplittable_ instead, and
simplifes the logic a bit, as well as being marginally faster.
> SplitSystemCatalogIT tests very unstable with Hbase 2.3
> -------------------------------------------------------
>
> Key: PHOENIX-6104
> URL: https://issues.apache.org/jira/browse/PHOENIX-6104
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Attachments: 6104-testouput.log
>
>
> The failure is in the test preparation code, where we split the system
> catalog table, and it seems to be a HBase issue, rather than a Phoenix one,
> but we need to track the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
