[
https://issues.apache.org/jira/browse/PHOENIX-6277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256305#comment-17256305
]
ASF GitHub Bot commented on PHOENIX-6277:
-----------------------------------------
virajjasani commented on a change in pull request #1039:
URL: https://github.com/apache/phoenix/pull/1039#discussion_r549944912
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2461,11 +2464,11 @@ public Object run() throws Exception {
try (PhoenixConnection connection =
QueryUtil.getConnectionOnServer(env.getConfiguration())
.unwrap(PhoenixConnection.class))
{
- try{
+ try {
MetaDataUtil.deleteFromStatsTable(connection,
deletedTable,
physicalTableNames, sharedTableStates);
- LOGGER.info("Table stats deleted successfully.
"+
-
deletedTable.getPhysicalName().getString());
+ LOGGER.info("Table stats deleted successfully.
"
+ +
deletedTable.getPhysicalName().getString());
Review comment:
same here
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
##########
@@ -342,12 +341,12 @@ public PhoenixResultSet call() throws SQLException {
}
//Force update cache and retry if meta not found error
occurs
catch (MetaDataEntityNotFoundException e) {
- if(doRetryOnMetaNotFoundError &&
e.getTableName()!=null){
- if(LOGGER.isDebugEnabled())
- LOGGER.debug("Reloading table "
- + e.getTableName()+" data from
server");
- if(new
MetaDataClient(connection).updateCache(connection.getTenantId(),
- e.getSchemaName(), e.getTableName(),
true).wasUpdated()){
+ if (doRetryOnMetaNotFoundError && e.getTableName() !=
null) {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Reloading table " +
e.getTableName() + " data from server");
Review comment:
Better replace with placeholder?
```
LOGGER.debug("Reloading table {} data from server", e.getTableName());
```
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
##########
@@ -430,12 +429,12 @@ public Integer call() throws SQLException {
}
//Force update cache and retry if meta not found
error occurs
catch (MetaDataEntityNotFoundException e) {
- if(doRetryOnMetaNotFoundError &&
e.getTableName()!=null){
- if(LOGGER.isDebugEnabled())
- LOGGER.debug("Reloading table "+
e.getTableName()
- +" data from server");
- if(new
MetaDataClient(connection).updateCache(connection.getTenantId(),
- e.getSchemaName(), e.getTableName(),
true).wasUpdated()){
+ if (doRetryOnMetaNotFoundError &&
e.getTableName() != null) {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Reloading table " +
e.getTableName() + " data from server");
Review comment:
same here
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -456,7 +457,7 @@
);
static {
- Collections.sort(COLUMN_KV_COLUMNS, KeyValue.COMPARATOR);
+ Collections.sort(COLUMN_KV_COLUMNS, CellComparator.getInstance());
Review comment:
Since we are sorting list, we can directly use sort():
```
COLUMN_KV_COLUMNS.sort(CellComparator.getInstance());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> upsert into data error after HBASE-24850,HBASE-24754 merged
> -----------------------------------------------------------
>
> Key: PHOENIX-6277
> URL: https://issues.apache.org/jira/browse/PHOENIX-6277
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0
> Reporter: Chao Wang
> Assignee: Chao Wang
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6277.master.001.patch,
> PHOENIX-6277.master.002.patch
>
>
> when HBASE-24850,HBASE-24754 merged, CellComparator perf improvement. phoenix
> use
> deprecated interface that compare byteBufferkeyvalue and keyvalue. throw
> "ByteBufferkeyvalue cannot be cast to keyvalue" when upsert data by
> sqlline.py.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
