[
https://issues.apache.org/jira/browse/PHOENIX-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256595#comment-17256595
]
ASF GitHub Bot commented on PHOENIX-6284:
-----------------------------------------
stoty commented on pull request #1044:
URL: https://github.com/apache/phoenix/pull/1044#issuecomment-752681623
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 55s | 4.x passed |
| +1 :green_heart: | compile | 0m 59s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 27s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 2m 58s | phoenix-core in 4.x has 962 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 26s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 131m 57s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate
ASF License warnings. |
| | | 162m 59s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1044/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1044 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux fc9dc9bb8748 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 0e8bef1 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1044/1/testReport/
|
| Max. process+thread count | 6074 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1044/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Flaky test UpgradeIT.testConcurrentUpgradeThrowsUpgradeInProgressException
> --------------------------------------------------------------------------
>
> Key: PHOENIX-6284
> URL: https://issues.apache.org/jira/browse/PHOENIX-6284
> Project: Phoenix
> Issue Type: Test
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> UpgradeIT.testConcurrentUpgradeThrowsUpgradeInProgressException is sometimes
> failing with error logs:
> e.g
> https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/166/testReport/org.apache.phoenix.end2end/UpgradeIT/MatrixBuild___Matrix___HBASE_PROFILE____2_1____BuildAndTest___testConcurrentUpgradeThrowsUprgadeInProgressException/
> {code:java}
> java.lang.AssertionError: One and only one thread should have acquired the
> mutex . Actual: true
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failEquals(Assert.java:187)
> at org.junit.Assert.assertNotEquals(Assert.java:163)
> at
> org.apache.phoenix.end2end.UpgradeIT.testConcurrentUpgradeThrowsUprgadeInProgressException(UpgradeIT.java:237)
> {code}
> While testing if 2 threads can simultaneously acquire lock, we release the
> lock immediately in finally for individual thread if it had acquired the
> mutex. This can lead to failure if one of the threads starts executing (due
> to slowness) only after the other thread releases mutex cell. In that case,
> the sequence of mutex acquisition would be:
> Thread1 acquires -> Thread1 releases -> Thread2 acquires -> Thread2 releases
> Because of this sequence, the above mentioned AssertionError can occur.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
