virajjasani commented on a change in pull request #1057:
URL: https://github.com/apache/phoenix/pull/1057#discussion_r551724919
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -484,6 +484,20 @@ private void openConnection() throws SQLException {
}
}
+ /**
+ * Close the HBase connection and decrement the counter.
+ * @throws IOException throws IOException
+ */
+ private void closeConnection() throws IOException {
+ if (connection != null) {
+ connection.close();
+ LOGGER.info("HConnection closed. Stacktrace for informational"
+ + " purposes: " + connection + " "
+ + LogUtil.getCallerStackTrace());
Review comment:
How about
```
LOGGER.info("{} HConnection closed. Stacktrace for informational purposes:
{}", connection, LogUtil.getCallerStackTrace());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
