[
https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259354#comment-17259354
]
Hadoop QA commented on PHOENIX-5923:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 6m
1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
15s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
9s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
41s{color} | {color:blue} phoenix-core in 4.x has 962 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
6s{color} | {color:red} phoenix-core: The patch generated 108 new + 4629
unchanged - 52 fixed = 4737 total (was 4681) {color} |
| {color:green}+1{color} | {color:green} prototool {color} | {color:green} 0m
3s{color} | {color:green} There were no new prototool issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m
58s{color} | {color:red} phoenix-core generated 1 new + 960 unchanged - 2 fixed
= 961 total (was 962) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}135m 50s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
47s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}176m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| | index must be non-null but is marked as nullable At
IndexMaintainer.java:is marked as nullable At IndexMaintainer.java:[line 188] |
| Failed junit tests | phoenix.end2end.index.SaltedIndexIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-5923 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13018202/PHOENIX-5923.4.x.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux 0904f7d445c0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / dc51bfd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/artifact/patchprocess/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/artifact/patchprocess/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/testReport/ |
| asflicense |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/artifact/patchprocess/patch-asflicense-problems.txt
|
| Max. process+thread count | 5649 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/342/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Supporting the single cell storage format for mutable global indexes
> --------------------------------------------------------------------
>
> Key: PHOENIX-5923
> URL: https://issues.apache.org/jira/browse/PHOENIX-5923
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5923.4.x.001.patch, PHOENIX-5923.master.001.patch
>
>
> It is known that IMMUTABLE_STORAGE_SCHEME = SINGLE_CELL_ARRAY_WITH_OFFSETS
> leads to performance improvement and storage saving. As the name implies this
> storage scheme is currently supported for immutable tables only. Supporting
> the SINGLE_CELL_ARRAY_WITH_OFFSETS storage format for mutable table requires
> reading existing rows for before mutating them, i.e., read-modify-write.
> However, this storage scheme can be used for mutable global index tables
> without any additional IO operation since for every index table update, we
> always read the corresponding data table row and generate the full index row
> from the current state of the data table row and the pending mutation on this
> row. This full index row can be stored using the
> SINGLE_CELL_ARRAY_WITH_OFFSETS storage format even though the data table can
> continue using a mutable storage format. This will allow index tables to
> enjoy the performance improvement and storage saving due to this storage
> format.
>
> Gokcen Iskender: We can also repurpose this Jira and add immutable tables as
> well. We can say that the Immutable tables can have ONE_CELL_PER_COLUMN
> storage format and have indexes that have SINGLE_CELL_ARRAY_WITH_OFFSETS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
