[
https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259511#comment-17259511
]
ASF GitHub Bot commented on PHOENIX-3499:
-----------------------------------------
dbwong commented on a change in pull request #1065:
URL: https://github.com/apache/phoenix/pull/1065#discussion_r552440369
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/CsvBulkImportUtil.java
##########
@@ -69,8 +69,11 @@ public static void configurePreUpsertProcessor(Configuration
conf,
}
@VisibleForTesting
- static void setChar(Configuration conf, String confKey, char charValue) {
- conf.set(confKey,
Bytes.toString(Base64.getEncoder().encode(Character.toString(charValue).getBytes())));
+
+ static void setChar(Configuration conf, String confKey, Character
charValue) {
+ if(charValue!=null) {
Review comment:
Can you explain the reason for the null check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable null value for quote character for CSVBulkLoad tool
> ----------------------------------------------------------
>
> Key: PHOENIX-3499
> URL: https://issues.apache.org/jira/browse/PHOENIX-3499
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.7.0, 4.8.0
> Reporter: Sergey Soldatov
> Assignee: Istvan Toth
> Priority: Major
> Attachments: PHOENIX-3499-1.patch
>
>
> It's quite often that CSV data contains '"' character as part of the user
> data. At the moment user has to replace quote character with something that
> is not used in the data. More convenient if we allow to set it to null (using
> empty character).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
