stoty commented on a change in pull request #1065:
URL: https://github.com/apache/phoenix/pull/1065#discussion_r552444714
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/CsvBulkImportUtil.java
##########
@@ -69,8 +69,11 @@ public static void configurePreUpsertProcessor(Configuration
conf,
}
@VisibleForTesting
- static void setChar(Configuration conf, String confKey, char charValue) {
- conf.set(confKey,
Bytes.toString(Base64.getEncoder().encode(Character.toString(charValue).getBytes())));
+
+ static void setChar(Configuration conf, String confKey, Character
charValue) {
+ if(charValue!=null) {
Review comment:
org.apache.phoenix.mapreduce.CsvBulkImportUtil.getCharacter(Configuration,
String) checks to see if the property is set, and will default to null, when it
isn't.
It is a very circumspect way of passing a null value, but that's how the
existing code works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
