[
https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259712#comment-17259712
]
ASF GitHub Bot commented on PHOENIX-3633:
-----------------------------------------
virajjasani commented on a change in pull request #1070:
URL: https://github.com/apache/phoenix/pull/1070#discussion_r552610534
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/SubqueryIT.java
##########
@@ -528,10 +528,29 @@ public void testExistsSubquery() throws Exception {
assertEquals(rs.getString(4), "T1");
assertFalse(rs.next());
-
+
rs = conn.createStatement().executeQuery("EXPLAIN " + query);
String plan = QueryUtil.getExplainPlan(rs);
assertPlansMatch(plans[2], plan);
+
+ //PHOENIX-3633
+ query = "SELECT * FROM " + tableName4 + " o WHERE NOT EXISTS
(SELECT 1 FROM " + tableName1 + " i WHERE \"item_id\" = 'does not exist')";
+ statement = conn.prepareStatement(query);
+ statement = conn.prepareStatement(query);
Review comment:
nit: repeated
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
##########
@@ -1217,8 +1217,10 @@ public boolean visitEnter(ExistsParseNode node) throws
SQLException {
@Override
public Expression visitLeave(ExistsParseNode node, List<Expression> l)
throws SQLException {
LiteralExpression child = (LiteralExpression) l.get(0);
- PhoenixArray array = (PhoenixArray) child.getValue();
- return LiteralExpression.newConstant(array.getDimensions() > 0 ^
node.isNegate(), PBoolean.INSTANCE);
+ boolean exists = child != null
Review comment:
nit: could be `elementExists`? It's upto you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> null pointer exception when subsquery for not exists returns empty result set
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-3633
> URL: https://issues.apache.org/jira/browse/PHOENIX-3633
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.7.0, 5.1.0
> Reporter: N Campbell
> Assignee: Istvan Toth
> Priority: Major
> Attachments: PHOENIX-3633.patch
>
>
> phoenix-4.7.0.2.5.3.0-37-client
> select RNUM, C1, C2 from TJOIN2 where not exists ( select C1 from TJOIN1
> where C2=500)
> Error while executing SQL "select RNUM, C1, C2 from TJOIN2 where not exists (
> select C1 from TJOIN1 where C2=500)": Remote driver error:
> NullPointerException: (null exception message)
> create table if not exists TJOIN1 (RNUM integer not null primary key , C1
> integer, C2 integer);
> upsert into TJOIN1 (RNUM, C1, C2) values ( 0, 10, 15);
> upsert into TJOIN1 (RNUM, C1, C2) values ( 1, 20, 25);
> upsert into TJOIN1 (RNUM, C1, C2) values ( 2, NULL, 50);
> create table if not exists TJOIN2 (RNUM integer not null primary key , C1
> integer, C2 char(2));
> upsert into TJOIN2 (RNUM, C1, C2) values ( 0, 10, 'BB');
> upsert into TJOIN2 (RNUM, C1, C2) values ( 1, 15, 'DD');
> upsert into TJOIN2 (RNUM, C1, C2) values ( 2, NULL, 'EE');
> upsert into TJOIN2 (RNUM, C1, C2) values ( 3, 10, 'FF');
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
