[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260879#comment-17260879
]
ASF GitHub Bot commented on PHOENIX-6120:
-----------------------------------------
stoty commented on pull request #1077:
URL: https://github.com/apache/phoenix/pull/1077#issuecomment-756446900
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 39s | 4.x passed |
| +1 :green_heart: | compile | 0m 58s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 26s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 44s | 4.x passed |
| +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.x has 961 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 42s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 25s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 197m 8s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate
ASF License warnings. |
| | | 231m 40s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1077/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1077 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux d254221143a9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 43b56d4 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1077/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1077/1/testReport/
|
| Max. process+thread count | 6204 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1077/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change IndexMaintainer for SINGLE_CELL_ARRAY_WITH_OFFSETS indexes. Currently
> it assumes data and index table having the same storage and encoding format.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6120
> URL: https://issues.apache.org/jira/browse/PHOENIX-6120
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-6120-addendum.4.x.001.patch,
> PHOENIX-6120.4.x.001.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This Jira is a followup Jira of PHOENIX-5923 where data and index might have
> different storage and encoding formats. IndexMaintainer and protobuf needs to
> change to handle this. Right now, index maintainer assumes both index and
> data tables have the same format. The protobuf needs to be changed so that
> IndexMaintainer knows about the data table storage and encoding formats
> Repro:
> # Create a table with ONE_CELL_PER_COLUMN storage format
> # Create an index that has covered columns and the IMMUTABLE_STORAGE_SCHEME
> is SINGLE_CELL_ARRAY_WITH_OFFSETS
> # Upsert rows to data table
> # Query the covered column using index --> Null value is returned even
> though there is a value.
> IndexMaintainer has a 4 year old code that doesn't return a value for covered
> columns,
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
