[
https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261066#comment-17261066
]
chenglei edited comment on PHOENIX-6211 at 1/8/21, 7:36 AM:
------------------------------------------------------------
[~kozdemir], I have read your patch and just have some suggestions for your
reference :
# Do you have any configuration to turn on and turn off this new feature
completely ? For new feature, I think we would better have a configuration to
turn on and turn off it completely and turn off it by default , just like
other Apache Project such as HBase and Spark does. After we are sure it is
stable in the next release, we could turn on it by default. After all, many
users had complained Phoenix is not very stable.
# Because the Scan Coprocessor is very critical for Phoenix, should we have
some Perf tests to show that there is no performance degrade after this patch ?
IMHO, only correctness test is not enough.
was (Author: comnetwork):
[~kozdemir], I have read your patch and just have some suggestions for your
reference :
# Do you have any configuration to turn on and turn off this new feature
completely ? For new feature, I think we would better have a configuration to
turn on and turn off it completely and disable it by default ,just like other
Apache Project such as HBase and Spark does. After we are sure it is stable in
the next release, we could enable it by default. After all, many users had
complained Phoenix is not very stable.
# Because the Scan Coprocessor is very critical for Phoenix, should we have
some Perf tests to show that there is no performance degrade after this patch ?
IMHO, only correctness test is not enough.
> Paged scan filters
> ------------------
>
> Key: PHOENIX-6211
> URL: https://issues.apache.org/jira/browse/PHOENIX-6211
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Critical
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6211.4.x.001.patch, PHOENIX-6211.4.x.002.patch,
> PHOENIX-6211.4.x.004.patch, PHOENIX-6211.4.x.005.patch,
> PHOENIX-6211.master.001.patch, PHOENIX-6211.master.002.patch,
> PHOENIX-6211.master.003.patch, PHOENIX-6211.master.004.patch,
> PHOENIX-6211.master.005.patch, PHOENIX-6211.master.006.patch,
> PHOENIX-6211.master.007.patch, PHOENIX-6211.master.008.patch,
> PHOENIX-6211.master.009.patch, PHOENIX-6211.master.010.patch
>
>
> Phoenix performs two main operations on the server side: aggregation and
> filtering. However, currently there is no internal Phoenix paging capability,
> and thus server side operations can take long enough to lead to HBase client
> timeouts. PHOENIX-5998 and PHOENIX-6207 are for providing the paging
> capability for ungrouped and grouped aggregate operations. This improvement
> Jira is for adding the paging capability for scan filters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
