[
https://issues.apache.org/jira/browse/PHOENIX-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262422#comment-17262422
]
ASF GitHub Bot commented on PHOENIX-6309:
-----------------------------------------
stoty commented on pull request #1082:
URL: https://github.com/apache/phoenix/pull/1082#issuecomment-757656611
On master, this is somewhat redundant, as dependency-check will fail the
build in these cases.
That was never backported to 4.x (but eventually should be)
However, as dependency-check runs AFTER the tests, and the tests still fail
more oftent than not, this may be useful if this runs before the tests, (and on
4.x.)
The commons-logging and commons-lang stuff definitely applies to 4.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use maven enforcer to ban imports
> ---------------------------------
>
> Key: PHOENIX-6309
> URL: https://issues.apache.org/jira/browse/PHOENIX-6309
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> We are already using mvn enforcer plugin for hbase version evaluations. We
> can extend it's usage to restrict-imports-enforcer-rule enforcer and ban
> imports from illegal packages (as per our project guidelines)
> e.g restrict usage of org.apache.commons.logging, com.google.common (in the
> presence of phoenix-thirdparty in Phoenix 5.x) etc.
> While doing backports from 4.x to master and vice-versa, it's quite common
> for these branch specific imports rules to get ignored by devs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
