[ 
https://issues.apache.org/jira/browse/PHOENIX-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262756#comment-17262756
 ] 

ASF GitHub Bot commented on PHOENIX-6307:
-----------------------------------------

stoty commented on pull request #1084:
URL: https://github.com/apache/phoenix/pull/1084#issuecomment-758062254


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  10m  5s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 25s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 57s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 11s |  root in the patch failed.  |
   | +1 :green_heart: |  compile  |   1m 27s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 27s |  the patch passed  |
   | -1 :x: |  markdownlint  |   0m  1s |  The patch generated 2 new + 28 
unchanged - 2 fixed = 30 total (was 30)  |
   | -1 :x: |  pylint  |   0m  4s |  The patch generated 5 new + 82 unchanged - 
19 fixed = 87 total (was 101)  |
   | -1 :x: |  shellcheck  |   0m  5s |  The patch generated 16 new + 7 
unchanged - 1 fixed = 23 total (was 8)  |
   | -1 :x: |  shelldocs  |   0m  2s |  The patch generated 10 new + 64 
unchanged - 0 fixed = 74 total (was 64)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m 10s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   1m 15s |  root in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 11s |  phoenix-assembly in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   1m 38s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 45s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  29m  1s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | 
phoenix.hbase.index.write.recovery.TestPerRegionIndexWriteCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1084 |
   | Optional Tests | dupname asflicense pylint markdownlint shellcheck 
shelldocs javac javadoc unit xml compile |
   | uname | Linux 83ff638e8ed7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 6d43aa2 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | markdownlint | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
 |
   | pylint | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/diff-patch-pylint.txt
 |
   | shellcheck | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
 |
   | shelldocs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/patch-javadoc-root.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/testReport/
 |
   | Max. process+thread count | 478 (vs. ulimit of 30000) |
   | modules | C: phoenix-client-parent/phoenix-client phoenix-server 
phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1084/2/console
 |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 markdownlint=0.22.0 
pylint=2.4.4 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Build and release official binary distributions with each HBase profile
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-6307
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6307
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> The release scripts curently assume that we release a single binary artifact 
> for Phoenix.
> Change the release scripts, so that binaries are built ans released for each 
> HBase profile.
> Also revert the change that omits the phoenix-compatibility classes from 
> phoenix-server, as it not needed, and a potentical source of problems with 
> this approach.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to