sakshamgangwar commented on a change in pull request #1079:
URL: https://github.com/apache/phoenix/pull/1079#discussion_r555417496



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableSnapshotResultIterator.java
##########
@@ -164,9 +165,6 @@ public void close() throws SQLException {
     closed = true; // ok to say closed even if the below code throws an 
exception
     try {
       scanIterator.close();
-      fs.delete(this.restoreDir, true);

Review comment:
       @gjacoby126 You are right Geoffrey! For our use case, we do clean up at 
the post-processing step for this restore directory too. Let me try to find a 
better place here as well to do the cleanup. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to