[
https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267316#comment-17267316
]
ASF GitHub Bot commented on PHOENIX-5296:
-----------------------------------------
virajjasani commented on a change in pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#discussion_r559600160
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java
##########
@@ -226,7 +225,8 @@ public void tickTime() {
}
@AfterClass
- public static synchronized void teardown() {
+ public static synchronized void teardown() throws Exception {
+ confirmStoreRefCountLeak();
Review comment:
Oh btw we don't need to worry about putting anything in finally after
calling BaseTest#confirmStoreRefCountLeak() because BaseTest is taking care of
shutting down miniCluster:
```
protected synchronized static void confirmStoreRefCountLeak()
throws Exception {
if (getUtility() != null) {
try {
CompatUtil.confirmStoreRefCountLeak(
getUtility().getAdmin());
} catch (IOException e) {
LOGGER.error("StoreFile refCount is leaked", e);
freeResources(false);
fail("StoreFile refCount is leaked");
}
}
}
```
freeResources() is doing the job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure store file reader refcount is zero at end of relevant unit tests
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5296
> URL: https://issues.apache.org/jira/browse/PHOENIX-5296
> Project: Phoenix
> Issue Type: Test
> Reporter: Andrew Kyle Purtell
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
>
> Unit and integration tests for functional areas where the implementation
> wraps scanners and uses a delegate pattern should check at the end of the
> test that no scanners were leaked (check that all scanners including the
> inner scanners were properly closed) by testing that the store reader
> reference count is zero on all stores.
> HBASE-22459 will offer a new metric and API which exposes this information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
