[
https://issues.apache.org/jira/browse/PHOENIX-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267838#comment-17267838
]
ASF GitHub Bot commented on PHOENIX-6327:
-----------------------------------------
stoty commented on a change in pull request #1099:
URL: https://github.com/apache/phoenix/pull/1099#discussion_r560105145
##########
File path: pom.xml
##########
@@ -350,41 +338,17 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
- <configuration>
- <reuseForks>true</reuseForks>
- <argLine>@{jacocoArgLine} -enableassertions -Xmx2000m
-XX:MaxPermSize=128m -Djava.security.egd=file:/dev/./urandom
"-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}"
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/
-Dorg.apache.hadoop.hbase.shaded.io.netty.packagePrefix=org.apache.hadoop.hbase.shaded.</argLine>
-
<groups>org.apache.phoenix.end2end.HBaseManagedTimeTest</groups>
- </configuration>
- <goals>
- <goal>integration-test</goal>
- <goal>verify</goal>
- </goals>
- </execution>
- <execution>
<id>NeedTheirOwnClusterTests</id>
<configuration>
<reuseForks>false</reuseForks>
- <argLine>@{jacocoArgLine} -enableassertions -Xmx2000m
-XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom
"-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}"
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/
-Dorg.apache.hadoop.hbase.shaded.io.netty.packagePrefix=org.apache.hadoop.hbase.shaded.</argLine>
Review comment:
It was needed for a very short time for shaded netty to find some of its
components, but it has long been fixed so that netty can autodetect it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove HBaseManagedTimeTest usages
> ----------------------------------
>
> Key: PHOENIX-6327
> URL: https://issues.apache.org/jira/browse/PHOENIX-6327
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Minor
>
> Phoenix has an HBaseManagedTimeTest category.
> However, there are only two pherf tests in this category, and I see no reason
> for thoseto have their own category.
> This looks like a leftover from some very old test setup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
