[
https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268621#comment-17268621
]
Hadoop QA commented on PHOENIX-5296:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 4m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
12s{color} | {color:green} master passed {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
21m 58s{color} | {color:black} HBase recompiled. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
37s{color} | {color:blue} phoenix-hbase-compat-2.4.0 in master has 1 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
33s{color} | {color:blue} phoenix-hbase-compat-2.3.0 in master has 1 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
33s{color} | {color:blue} phoenix-hbase-compat-2.2.1 in master has 1 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
34s{color} | {color:blue} phoenix-hbase-compat-2.1.6 in master has 1 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
8s{color} | {color:blue} phoenix-core in master has 955 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
22s{color} | {color:green} the patch passed {color} |
| {color:black}+0{color} | {color:black} hbaserecompile {color} | {color:black}
15m 6s{color} | {color:black} HBase recompiled. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
43s{color} | {color:red} root: The patch generated 17 new + 124 unchanged - 2
fixed = 141 total (was 126) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 0m
47s{color} | {color:green} phoenix-hbase-compat-2.4.0 in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 0m
46s{color} | {color:green} phoenix-hbase-compat-2.3.0 in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 0m
44s{color} | {color:green} phoenix-hbase-compat-2.2.1 in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 0m
47s{color} | {color:green} phoenix-hbase-compat-2.1.6 in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 3m
25s{color} | {color:green} phoenix-core generated 0 new + 954 unchanged - 1
fixed = 954 total (was 955) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}118m 45s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/374/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-5296 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13019061/PHOENIX-5296.master.000.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild
hbaseanti checkstyle compile xml |
| uname | Linux b47f1d9fd7dd 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 772ff2c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/374/artifact/patchprocess/diff-checkstyle-root.txt
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/374/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/374/testReport/ |
| Max. process+thread count | 9173 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-2.4.0 phoenix-hbase-compat-2.3.0
phoenix-hbase-compat-2.2.1 phoenix-hbase-compat-2.1.6 phoenix-core U: . |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/374/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Ensure store file reader refcount is zero at end of relevant unit tests
> -----------------------------------------------------------------------
>
> Key: PHOENIX-5296
> URL: https://issues.apache.org/jira/browse/PHOENIX-5296
> Project: Phoenix
> Issue Type: Test
> Reporter: Andrew Kyle Purtell
> Assignee: Viraj Jasani
> Priority: Major
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5296.4.x.000.patch,
> PHOENIX-5296.master.000.patch, PHOENIX-5296.master.000.patch
>
>
> Unit and integration tests for functional areas where the implementation
> wraps scanners and uses a delegate pattern should check at the end of the
> test that no scanners were leaked (check that all scanners including the
> inner scanners were properly closed) by testing that the store reader
> reference count is zero on all stores.
> HBASE-22459 will offer a new metric and API which exposes this information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
