virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561696831



##########
File path: pom.xml
##########
@@ -1545,6 +1547,7 @@
         <hbase.profile>2.1</hbase.profile>
         <hbase.compat.version>2.1.6</hbase.compat.version>
         <hbase.version>${hbase-2.1.runtime.version}</hbase.version>
+        <hadoop.version>3.0.3</hadoop.version>

Review comment:
       While confirming `hadoop-three.version` on branch-2.1, when I saw 
default value of `${hbase-2.1.runtime.version}` as `2.1.10` I was surprised to 
see only 2.1.10 RC tags available on HBase but release tag `rel/2.1.10` is 
missing!

##########
File path: pom.xml
##########
@@ -1560,6 +1563,7 @@
         <hbase.profile>2.2</hbase.profile>
         <hbase.compat.version>2.2.5</hbase.compat.version>
         <hbase.version>${hbase-2.2.runtime.version}</hbase.version>
+        <hadoop.version>3.1.3</hadoop.version>

Review comment:
       This could be 3.1.2 as latest HBase release 2.2.6 supports it: 
https://github.com/apache/hbase/blob/rel/2.2.6/pom.xml#L1373




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to