shahrs87 commented on a change in pull request #1079:
URL: https://github.com/apache/phoenix/pull/1079#discussion_r561902411
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
##########
@@ -191,6 +190,12 @@
// provide an absolute path to inject your multi input mapper logic
public static final String MAPREDUCE_MULTI_INPUT_MAPPER_TRACKER_CLAZZ =
"phoenix.mapreduce.multi.mapper.tracker.path";
+ // provide control to whether or not handle MR snapshot restore on phoenix
side or handled by caller externally
Review comment:
The naming convention for all other conf property starts with MAPREDUCE.
Do you mind changing the property name to something like:
"MAPREDUCE_SNAPSHOT_RESTORE_EXTERNAL" ? and prefix with DEFAULT for default
value ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
