virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561696831
##########
File path: pom.xml
##########
@@ -1545,6 +1547,7 @@
<hbase.profile>2.1</hbase.profile>
<hbase.compat.version>2.1.6</hbase.compat.version>
<hbase.version>${hbase-2.1.runtime.version}</hbase.version>
+ <hadoop.version>3.0.3</hadoop.version>
Review comment:
While confirming `hadoop-three.version` on branch-2.1, when I saw
default value of `${hbase-2.1.runtime.version}` as `2.1.10` I was surprised to
see only 2.1.10 RC tags available on HBase but release tag `rel/2.1.10` is
missing!
##########
File path: pom.xml
##########
@@ -1560,6 +1563,7 @@
<hbase.profile>2.2</hbase.profile>
<hbase.compat.version>2.2.5</hbase.compat.version>
<hbase.version>${hbase-2.2.runtime.version}</hbase.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
This could be 3.1.2 as latest HBase release 2.2.6 supports it:
https://github.com/apache/hbase/blob/rel/2.2.6/pom.xml#L1373
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
Same here https://github.com/apache/hbase/blob/rel/2.3.3/pom.xml#L1341
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
I see, I thought we want to keep the same default Hadoop version for
HBase profiles as the default Hadoop version kept by the respective HBase
versions.
> This only affects the defaults, and the binary distributions, end users
are free to build with wathever version they choose.
That's right, end users are free to build with versions of their choice.
> I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop
3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
Great!
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should
simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing
testing and all, maybe bake in multibranch build for few days and once we see
things clear, maybe we should proceed. Given all the work you have done, i
think good to proceed with updated Hadoop versions. Only if it turns out to
significant tests failing due to Hadoop upgrade, maybe we can revert and take
some time with individual HBase profiles. If we go in this situation, please
let me know, i will try to test specific HBase profile and try to help ensure
the least latest Hadoop version that we can support.
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should
simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing
testing and all, maybe bake in multibranch build for a couple of days and once
we see things clear, maybe we should proceed. Given all the work you have done,
i think good to proceed with updated Hadoop versions. Only if it turns out to
be significant tests failing due to Hadoop upgrade, maybe we can revert and
take some time with individual HBase profiles. If we go in this situation,
please let me know, i will try to test specific HBase profile and try to help
ensure the least latest Hadoop version that we can support.
On the other hand, builds you are running currently themselves should be
sufficient to know the stability I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
