[ 
https://issues.apache.org/jira/browse/PHOENIX-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269908#comment-17269908
 ] 

ASF GitHub Bot commented on PHOENIX-6330:
-----------------------------------------

stoty commented on pull request #1102:
URL: https://github.com/apache/phoenix/pull/1102#issuecomment-764828760


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 17s |  master passed  |
   | +0 |  hbaserecompile  |  23m  6s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 16s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 22s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m  2s |  master passed  |
   | +0 :ok: |  spotbugs  |   4m  2s |  phoenix-core in master has 955 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  10m 46s |  the patch passed  |
   | +0 |  hbaserecompile  |  22m 51s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 15s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 19s |  phoenix-core: The patch generated 1 
new + 2195 unchanged - 0 fixed = 2196 total (was 2195)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 15s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 200m  0s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 54s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 262m 12s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | 
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
   |   | phoenix.end2end.DisableLocalIndexIT |
   |   | phoenix.tx.TransactionIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1102/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1102 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs 
hbaserebuild hbaseanti checkstyle compile |
   | uname | Linux e4fc1a37d456 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 55f1362 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1102/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1102/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1102/2/testReport/
 |
   | Max. process+thread count | 13095 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1102/2/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> SystemCatalogRegionObserver isn't added when cluster is initialized with 
> isNamespaceMappingEnabled=true
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6330
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6330
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Critical
>
> When the cluster is initialized with 
> "phoenix.schema.isNamespaceMappingEnabled" = "true",   
> SystemCatalogRegionObserver is not added to SYSTEM:CATALOG.
> This negates the "select * from system.catalog" fix in PHOENIX-5712 (At 
> least).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to