virajjasani commented on a change in pull request #1106:
URL: https://github.com/apache/phoenix/pull/1106#discussion_r562683347
##########
File path: dev/phoenix-personality.sh
##########
@@ -87,9 +87,11 @@ function personality_globals
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
- # TODO Doesn't seem to have effect in Yetus 0.12, set in cli instead
#shellcheck disable=SC2034
- DOCKERMEMLIMIT=20g
+ DOCKER_MEMORY=20g
+
+ #Allow some swaping to avoid OOM errors
+ DOCKER_EXTRAARGS+=( "--memory-swap=24g" )
Review comment:
I was just looking up
https://docs.docker.com/config/containers/resource_constraints/ and found this:
```
--memory-swap is a modifier flag that only has meaning if --memory is also
set.
```
What we specify with `DOCKERMEMLIMIT` is treated as `--memory` by Yetus?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
