[
https://issues.apache.org/jira/browse/PHOENIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270353#comment-17270353
]
ASF GitHub Bot commented on PHOENIX-6250:
-----------------------------------------
ChinmaySKulkarni edited a comment on pull request #1105:
URL: https://github.com/apache/phoenix/pull/1105#issuecomment-765609975
> @yanxinyi View's not getting deleted while parent was dropped has
something to do with SYSTEM.TASK? Do we save some intermittent state while
dropping view in SYSTEM.TASK?
Yes we use the SYSTEM.TASK table for dropping child views asynchronously
whenever a drop <parent table/view> cascade command is issued. By setting these
configs, we are ensuring that the background TaskRegionObserver thread does not
automatically pick up DropChildViewTasks (by never scheduling these tasks in
the first place). This prevents race conditions in the test and makes it more
deterministic since we already explicitly call runDropChildViewsTask() in the
test wherever cascade drops are issued:
https://github.com/apache/phoenix/blob/ba6ad70541d9dae88ab574df3889f5fe2c0ef7fa/phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewMetadataIT.java#L720-L726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix ViewMetadataIT test flapper
> -------------------------------
>
> Key: PHOENIX-6250
> URL: https://issues.apache.org/jira/browse/PHOENIX-6250
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6250.4.x.v3.patch, PHOENIX-6250.master.v3.patch
>
>
> ViewMetadataIT failed multi-times at 4.x branch.
> Here is the logging:
> {code:java}
> 17:32:58 [ERROR] Tests run: 25, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 353.71 s <<< FAILURE! - in org.apache.phoenix.end2end.ViewMetadataIT
> 17:32:58 [ERROR]
> testRepeatedCreateAndDropCascadeTableWorks(org.apache.phoenix.end2end.ViewMetadataIT)
> Time elapsed: 11.52 s <<< FAILURE!
> 17:32:58 java.lang.AssertionError: View SCHEMA2.N000074 should have been
> deleted when parent was dropped
> 17:32:58 at org.junit.Assert.fail(Assert.java:89)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.validateViewDoesNotExist(ViewMetadataIT.java:1373)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.testRepeatedCreateAndDropCascadeTableWorks(ViewMetadataIT.java:818)
> 17:32:58 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 17:32:58 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 17:32:58 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 17:32:58 at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
