stoty commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564286071
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java
##########
@@ -81,27 +88,27 @@
private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG =
"SYSTEM:CATALOG";
private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
- private static final String MODIFIED_MAX_VERSIONS ="5";
+ private static final String MODIFIED_MAX_VERSIONS = "5";
private static final String CREATE_TABLE_STMT = "CREATE TABLE %s"
- + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY
KEY(K1,K2))";
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY
KEY(K1,K2))";
Review comment:
These line continuations do match the conventions in
https://phoenix.apache.org/contributing.html .
I know that we have code in much worse shape than this, but since you are
fixing formatting, we might as well do it by the book.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
