[ 
https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272000#comment-17272000
 ] 

ASF GitHub Bot commented on PHOENIX-6339:
-----------------------------------------

stoty commented on pull request #1111:
URL: https://github.com/apache/phoenix/pull/1111#issuecomment-767414314


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  14m 42s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   1m 25s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   0m 45s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   3m  0s |  phoenix-core in 4.x has 945 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  4s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 30s |  phoenix-core: The patch generated 40 
new + 2377 unchanged - 29 fixed = 2417 total (was 2406)  |
   | +1 :green_heart: |  whitespace  |   0m  1s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 43s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 14s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 128m 43s |  phoenix-core in the patch passed.  
|
   | +1 :green_heart: |  asflicense  |   0m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 163m 51s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1111/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1111 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile |
   | uname | Linux e3727bcf4df8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 51715b3 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1111/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1111/1/testReport/
 |
   | Max. process+thread count | 5655 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1111/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Older client using aggregate queries shows incorrect results.
> -------------------------------------------------------------
>
>                 Key: PHOENIX-6339
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6339
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Jacob Isaac
>            Assignee: Kadir OZDEMIR
>            Priority: Blocker
>             Fix For: 4.16.0
>
>
> When running an older client for eg (4.15) against a 4.16 server
> The output of aggregate queries are incorrect -
> expected one row with the count, actual 9 rows with counts.
> The 9 rows correspond to the number of regions in the data set. As shown in 
> the explain plan.
> Connected to: Phoenix (version 4.15)
> Driver: PhoenixEmbeddedDriver (version 4.15)
> Autocommit status: true
> Transaction isolation: TRANSACTION_READ_COMMITTED
> Building list of tables and columns for tab-completion (set fastconnect to 
> true to skip)...
> 225/225 (100%) Done
> Done
> sqlline version 1.5.0
> 0: jdbc:phoenix:localhost> select count(*) from 
> BENCHMARK.BM_AGGREGATION_TABLE_2;
> +-----------+
> | COUNT(1) |
> +-----------+
> | 2389483 |
> | 2319177 |
> | 1958007 |
> | 2389483 |
> | 2319178 |
> | 1958005 |
> | 2233646 |
> | 2249033 |
> | 2183988 |
> +-----------+
> 9 rows selected (6.56 seconds)
> 0: jdbc:phoenix:localhost> explain select count(*) from 
> BENCHMARK.BM_AGGREGATION_TABLE_2;
> +---------------------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+
> | PLAN | EST_BYTES_READ | EST_ROWS_READ | EST_INFO_TS |
> +---------------------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+
> | CLIENT 9-CHUNK 10191406 ROWS 1887436990 BYTES PARALLEL 1-WAY FULL SCAN OVER 
> BENCHMARK.BM_AGGREGATION_TABLE_2 | 1887436990 | 10191406 | 1611584394492 |
> | SERVER FILTER BY FIRST KEY ONLY | 1887436990 | 10191406 | 1611584394492 |
> | SERVER AGGREGATE INTO SINGLE ROW | 1887436990 | 10191406 | 1611584394492 |
> +---------------------------------------------------------------------------------------------------------------+-----------------+----------------+----------------+



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to