virajjasani commented on a change in pull request #1114:
URL: https://github.com/apache/phoenix/pull/1114#discussion_r565095342
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/RoundRobinResultIterator.java
##########
@@ -114,6 +114,7 @@ public Tuple next() throws SQLException {
index = (index + 1) % size;
}
}
+ close();
Review comment:
It seems we already do have practice of closing iterators when next()
exhausts all rows e.g `ConcatResultIterator`, `LimitingResultIterator`. I think
we are good here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
