[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273373#comment-17273373
]
ASF GitHub Bot commented on PHOENIX-6343:
-----------------------------------------
stoty commented on pull request #1117:
URL: https://github.com/apache/phoenix/pull/1117#issuecomment-768844100
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 17m 11s | master passed |
| +0 | hbaserecompile | 24m 10s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 4s | master passed |
| +1 :green_heart: | checkstyle | 1m 17s | master passed |
| +1 :green_heart: | javadoc | 0m 53s | master passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in master has 954 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 13s | the patch passed |
| +0 | hbaserecompile | 21m 24s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 16s | the patch passed |
| +1 :green_heart: | javac | 1m 16s | the patch passed |
| -1 :x: | checkstyle | 1m 30s | phoenix-core: The patch generated 1
new + 2869 unchanged - 0 fixed = 2870 total (was 2869) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed |
| +1 :green_heart: | spotbugs | 4m 2s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 2m 1s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate
ASF License warnings. |
| | | 66m 1s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.compile.SelectStatementRewriterTest |
| | phoenix.query.ExplainPlanTextTest |
| | phoenix.util.json.JsonUpsertExecutorTest |
| | phoenix.schema.MutationTest |
| | phoenix.jdbc.PhoenixDriverTest |
| | phoenix.compile.QueryMetaDataTest |
| | phoenix.compile.PostIndexDDLCompilerTest |
| | phoenix.index.VerifySingleIndexRowTest |
| | phoenix.query.ParallelIteratorsSplitTest |
| | phoenix.compile.WhereCompilerTest |
| | phoenix.compile.CursorCompilerTest |
| | phoenix.query.QueryPlanTest |
| | phoenix.compile.JoinQueryCompilerTest |
| | phoenix.query.OrderByTest |
| | phoenix.util.ScanUtilTest |
| | phoenix.query.PropertyPolicyProviderTest |
| | phoenix.schema.RowKeySchemaTest |
| | phoenix.expression.NullValueTest |
| | phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest |
| | phoenix.compile.ViewCompilerTest |
| | phoenix.compile.QueryOptimizerTest |
| | phoenix.mapreduce.util.IndexColumnNamesTest |
| | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
| | phoenix.jdbc.PhoenixResultSetMetadataTest |
| | phoenix.mapreduce.index.IndexScrutinyTableOutputTest |
| | phoenix.util.csv.StringToArrayConverterTest |
| | phoenix.compile.TenantSpecificViewIndexCompileTest |
| | phoenix.compile.LimitCompilerTest |
| | phoenix.compile.StatementHintsCompilationTest |
| | phoenix.util.PhoenixRuntimeTest |
| | phoenix.schema.RowKeyValueAccessorTest |
| | phoenix.expression.RoundFloorCeilExpressionsTest |
| | phoenix.index.PrepareIndexMutationsForRebuildTest |
| | phoenix.hbase.index.covered.NonTxIndexBuilderTest |
| | phoenix.jdbc.PhoenixPreparedStatementTest |
| | phoenix.compile.HavingCompilerTest |
| | phoenix.index.IndexMaintainerTest |
| | phoenix.query.KeyRangeClipTest |
| | phoenix.util.PhoenixEncodeDecodeTest |
| | phoenix.compile.QueryCompilerTest |
| | phoenix.compile.WhereOptimizerTest |
| | phoenix.query.ScannerLeaseRenewalTest |
| | phoenix.index.IndexScrutinyMapperTest |
| | phoenix.util.csv.CsvUpsertExecutorTest |
| | phoenix.schema.MetaDataClientTest |
| | phoenix.iterate.AggregateResultScannerTest |
| | phoenix.compile.CreateTableCompilerTest |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1117 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux ef3b73854e0d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 79c66fd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/testReport/
|
| Max. process+thread count | 428 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1117/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Phoenix allows duplicate column names when one of them is a primary key
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6343
> URL: https://issues.apache.org/jira/browse/PHOENIX-6343
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Istvan Toth
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.1, 4.17.0
>
>
> {code:sql}
> CREATE TABLE IF NOT EXISTS test_duplicate_columns (
> name VARCHAR NOT NULL PRIMARY KEY,
> city VARCHAR, name VARCHAR);
> {code}
> {noformat}
> select * from test_duplicate_columns;
> +------+------+------+
> | NAME | CITY | NAME |
> +------+------+------+
> +------+------+------+
> No rows selected (0.015 seconds)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
