[
https://issues.apache.org/jira/browse/PHOENIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273461#comment-17273461
]
ASF GitHub Bot commented on PHOENIX-5543:
-----------------------------------------
stoty commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-768927752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 4m 59s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 50s | 4.x passed |
| +1 :green_heart: | compile | 1m 35s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 9s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 3s | 4.x passed |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-pherf in 4.x has 42 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 50s | the patch passed |
| +1 :green_heart: | compile | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 278
new + 3380 unchanged - 143 fixed = 3658 total (was 3523) |
| -1 :x: | checkstyle | 0m 15s | phoenix-pherf: The patch generated 1
new + 182 unchanged - 6 fixed = 183 total (was 188) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | javadoc | 1m 0s | the patch passed |
| -1 :x: | spotbugs | 3m 14s | phoenix-core generated 5 new + 940
unchanged - 5 fixed = 945 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 204m 24s | phoenix-core in the patch failed. |
| +1 :green_heart: | unit | 10m 13s | phoenix-pherf in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 33s | The patch does not generate
ASF License warnings. |
| | | 262m 47s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.util.QueryUtil.getCatalogsStmt(PhoenixConnection)
may fail to clean up java.sql.Statement on checked exception Obligation to
clean up resource created at QueryUtil.java:up java.sql.Statement on checked
exception Obligation to clean up resource created at QueryUtil.java:[line 528]
is not discharged |
| | org.apache.phoenix.util.QueryUtil.getIndexInfoStmt(PhoenixConnection,
String, String, String, boolean, boolean) may fail to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:boolean) may fail to clean up java.sql.Statement on
checked exception Obligation to clean up resource created at
QueryUtil.java:[line 633] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getSchemasStmt(PhoenixConnection,
String, String) may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:[line 558] is not discharged |
| |
org.apache.phoenix.util.QueryUtil.getSuperTablesStmt(PhoenixConnection, String,
String, String) may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:fail to clean up
java.sql.Statement on checked exception Obligation to clean up resource
created at QueryUtil.java:[line 588] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getTablesStmt(PhoenixConnection,
String, String, String, String[]) may fail to clean up java.sql.Statement on
checked exception Obligation to clean up resource created at
QueryUtil.java:may fail to clean up java.sql.Statement on checked exception
Obligation to clean up resource created at QueryUtil.java:[line 763] is not
discharged |
| Failed junit tests | phoenix.end2end.DropTableWithViewsIT |
| | phoenix.end2end.UpsertSelectIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1116 |
| JIRA Issue | PHOENIX-5543 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 98f076aa7d87 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 44d4402 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/testReport/
|
| Max. process+thread count | 4838 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement show schemas / show tables SQL commands
> -------------------------------------------------
>
> Key: PHOENIX-5543
> URL: https://issues.apache.org/jira/browse/PHOENIX-5543
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Bharath Vissapragada
> Assignee: Bharath Vissapragada
> Priority: Minor
> Fix For: 5.1.0, 4.16.1, 4.17.0
>
> Attachments: PHOENIX-5543-4.x.v1.patch, PHOENIX-5543.master.v1.patch,
> PHOENIX-5543.master.v2.patch, PHOENIX-5543.master.v3.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently users rely on {{!tables}} and {{!schemas}} commands provided by
> sqlline which pulls the information using the standard JDBC metadata calls
> like {{getTables()}} and {{getSchemas()}}.
> Most other databases (like mysql[1,2]) implement these as first class SQL
> commands that gives the user more flexibility in querying by adding necessary
> filters and looking up for table information in specific schemas. The ask
> here is to implement the following SQL commands.
> {noformat}
> SHOW SCHEMAS [LIKE '<pattern>']
> SHOW TABLES [IN <schema>] [LIKE '<pattern>']
> {noformat}
> [1] https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
> [2] https://dev.mysql.com/doc/refman/8.0/en/show-databases.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
