virajjasani commented on pull request #1118: URL: https://github.com/apache/phoenix/pull/1118#issuecomment-769003852
Nice points. > Do we store the PK field(s) in actual cell, or are they only present in the rowkey ? For user created tables, their pk (and non-pk) columns are actually rowkeys in SYSTEM.CATALOG. The cells represent specific properties like `DATA_TYPE`, `NULLABLE` etc. > What happens when you specify a CF for a PK field ? is it even valid ? I think we can't specify CF for PK. We have this special Exception for it: `PRIMARY_KEY_WITH_FAMILY_NAME` Based on some unit tests written very initially, it seems we do allow creating same column name (with user defined columnFamily) as Pk column name, but that is the very reason why the same would apply to default columnFamily and hence, any user created table can have Pk and non-Pk column names same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
