[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273771#comment-17273771
]
ASF GitHub Bot commented on PHOENIX-6343:
-----------------------------------------
gjacoby126 commented on a change in pull request #1118:
URL: https://github.com/apache/phoenix/pull/1118#discussion_r566146481
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java
##########
@@ -90,6 +91,113 @@ public void testStartKeyStopKey() throws SQLException {
assertTrue(splits.size() > 0);
}
+ @Test
+ public void testCreateAlterTableWithDuplicateColumn() throws Exception {
+ Properties props = new Properties();
+ int failureCount = 0;
+ int expectedExecCount = 0;
+ String tableName = generateUniqueName();
+ String viewName = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ try {
+ conn.createStatement().execute(String.format("CREATE TABLE %s"
Review comment:
nit: Would be good if before each case there was a brief comment
explaining it -- e.g "Same column name, different column type" for the third
one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Phoenix allows duplicate column names when one of them is a primary key
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6343
> URL: https://issues.apache.org/jira/browse/PHOENIX-6343
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Istvan Toth
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.1, 4.17.0
>
>
> {code:sql}
> CREATE TABLE IF NOT EXISTS test_duplicate_columns (
> name VARCHAR NOT NULL PRIMARY KEY,
> city VARCHAR, name VARCHAR);
> {code}
> {noformat}
> select * from test_duplicate_columns;
> +------+------+------+
> | NAME | CITY | NAME |
> +------+------+------+
> +------+------+------+
> No rows selected (0.015 seconds)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
