stoty commented on pull request #1122: URL: https://github.com/apache/phoenix/pull/1122#issuecomment-770088060
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 4m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 15s | master passed | | +0 | hbaserecompile | 22m 25s | HBase recompiled. | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | checkstyle | 1m 48s | master passed | | +1 :green_heart: | javadoc | 2m 53s | master passed | | +0 :ok: | spotbugs | 4m 19s | root in master has 1004 extant spotbugs warnings. | | +0 :ok: | spotbugs | 3m 1s | phoenix-core in master has 954 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 45s | phoenix-pherf in master has 42 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 43s | phoenix-tools in master has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 16s | the patch passed | | +0 | hbaserecompile | 14m 54s | HBase recompiled. | | +1 :green_heart: | compile | 1m 32s | the patch passed | | +1 :green_heart: | javac | 1m 32s | the patch passed | | -1 :x: | checkstyle | 1m 49s | root: The patch generated 1 new + 2766 unchanged - 1 fixed = 2767 total (was 2767) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 54s | the patch passed | | -1 :x: | spotbugs | 3m 15s | phoenix-core generated 9 new + 945 unchanged - 9 fixed = 954 total (was 954) | | -1 :x: | spotbugs | 1m 6s | phoenix-pherf generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) | | -1 :x: | spotbugs | 0m 59s | phoenix-tools generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3) | | -1 :x: | spotbugs | 4m 34s | root generated 11 new + 993 unchanged - 11 fixed = 1004 total (was 1004) | ||| _ Other Tests _ | | -1 :x: | unit | 116m 18s | root in the patch failed. | | -1 :x: | asflicense | 1m 17s | The patch generated 611 ASF License warnings. | | | | 189m 13s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 137] | | | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 181] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] | | | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 857] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 355] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 240] | | | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 210] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 276] | | FindBugs | module:phoenix-pherf | | | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 207] | | FindBugs | module:phoenix-tools | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] | | FindBugs | module:root | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 137] | | | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 181] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] | | | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 857] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 355] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 240] | | | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 210] | | | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 207] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 276] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1122 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle | | uname | Linux 95e8e09819bb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 22f7d41 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/new-spotbugs-root.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 13351 (vs. ulimit of 30000) | | modules | C: phoenix-core phoenix-pherf phoenix-tools . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1122/3/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
