[
https://issues.apache.org/jira/browse/PHOENIX-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277101#comment-17277101
]
ASF GitHub Bot commented on PHOENIX-6182:
-----------------------------------------
stoty commented on pull request #1126:
URL: https://github.com/apache/phoenix/pull/1126#issuecomment-771616426
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
5 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 19s | master passed |
| +0 | hbaserecompile | 22m 43s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | checkstyle | 1m 42s | master passed |
| +1 :green_heart: | javadoc | 0m 54s | master passed |
| +0 :ok: | spotbugs | 3m 5s | phoenix-core in master has 955 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 18s | the patch passed |
| +0 | hbaserecompile | 17m 48s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 1m 50s | phoenix-core: The patch generated 244
new + 2773 unchanged - 56 fixed = 3017 total (was 2829) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| -1 :x: | spotbugs | 3m 12s | phoenix-core generated 4 new + 955
unchanged - 0 fixed = 959 total (was 955) |
||| _ Other Tests _ |
| -1 :x: | unit | 103m 4s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate
ASF License warnings. |
| | | 162m 24s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES
is a mutable array At IndexVerificationResultRepository.java: At
IndexVerificationResultRepository.java:[line 138] |
| |
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES
is a mutable array At IndexVerificationResultRepository.java: At
IndexVerificationResultRepository.java:[line 135] |
| |
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES
is a mutable array At IndexVerificationResultRepository.java: At
IndexVerificationResultRepository.java:[line 131] |
| |
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES
is a mutable array At IndexVerificationResultRepository.java: At
IndexVerificationResultRepository.java:[line 128] |
| Failed junit tests |
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1126 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs
hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 1ba911bd743f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / d4021de |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/artifact/yetus-general-check/output/whitespace-eol.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/testReport/
|
| Max. process+thread count | 14920 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1126/7/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> IndexTool to verify and repair every index row
> ----------------------------------------------
>
> Key: PHOENIX-6182
> URL: https://issues.apache.org/jira/browse/PHOENIX-6182
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Kadir OZDEMIR
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 4.16.0, 4.16.1
>
>
> IndexTool rebuilds and verifies every index row pointed by the data table.
> However, IndexTool cannot clean up the index rows that are not referenced by
> the data table if there are such index rows. In order to do that it needs to
> scan index table regions and make sure that every index row is valid. For
> example we can add an option called source table (as in IndexScrutinyTool) to
> do repair and verify index rows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
