[
https://issues.apache.org/jira/browse/PHOENIX-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278553#comment-17278553
]
ASF GitHub Bot commented on PHOENIX-6356:
-----------------------------------------
stoty commented on pull request #1130:
URL: https://github.com/apache/phoenix/pull/1130#issuecomment-773046090
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 24s | 4.x passed |
| +1 :green_heart: | compile | 1m 4s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 38s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 18s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 0m 37s | phoenix-core: The patch generated 6
new + 630 unchanged - 6 fixed = 636 total (was 636) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 29s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 180m 28s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate
ASF License warnings. |
| | | 223m 22s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.MapReduceIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1130 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 497fd7b7fa1c 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 4bd1ec5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/testReport/
|
| Max. process+thread count | 4997 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> missing row.clear() for dummy row in GlobalIndexRegionScanner
> -------------------------------------------------------------
>
> Key: PHOENIX-6356
> URL: https://issues.apache.org/jira/browse/PHOENIX-6356
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.x
> Reporter: Istvan Toth
> Priority: Major
>
> While porting PHOENIX-6182 to master, I run into a problem in
> GlobalIndexRegionScanner where the returned dummy row is passed to the
> next(row) call.
> I have added the missing clear statement to the master patch, which fixed the
> test case.
> This doesn't seem to affect the test on 4.x, but breaks it on master.
> At least this fix should be backported to 4.x.
> Someone with a better understanding of the paging code should probably check
> if similar issues are present at other places.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
