[
https://issues.apache.org/jira/browse/PHOENIX-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281648#comment-17281648
]
ASF GitHub Bot commented on PHOENIX-6344:
-----------------------------------------
stoty commented on pull request #1135:
URL: https://github.com/apache/phoenix/pull/1135#issuecomment-775787461
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 34s | 4.x passed |
| +1 :green_heart: | compile | 1m 6s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 13s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 47s | the patch passed |
| +1 :green_heart: | compile | 1m 8s | the patch passed |
| +1 :green_heart: | javac | 1m 8s | the patch passed |
| -1 :x: | checkstyle | 1m 17s | phoenix-core: The patch generated 2
new + 2856 unchanged - 1 fixed = 2858 total (was 2857) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 182m 9s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate
ASF License warnings. |
| | | 219m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1135/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1135 |
| JIRA Issue | PHOENIX-6344 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux b3ccb2e616ff 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 0d5bb3e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1135/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1135/2/testReport/
|
| Max. process+thread count | 4928 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1135/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CASCADE on ALTER should NOOP when there are no secondary indexes
> ----------------------------------------------------------------
>
> Key: PHOENIX-6344
> URL: https://issues.apache.org/jira/browse/PHOENIX-6344
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
> Fix For: 5.1.0, 4.16.1, 4.17.0
>
>
> When a table/view does not have a secondary index, using cascade in the ALTER
> TABLE/VIEW .. ADD <column> should continue with default behavior (of only
> adding the column to table/view like a regular alter statement)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
