stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777046828


   > One thing we might want to consider is an import dependency so we can 
share a single pom across all of these client flavours. Any thoughts?
   
   I don't really get what you mean. We are already have most common setting in 
the parent pom. Can you add a little more detail ?
   
   > EDIT: I guess it is not clear from the JIRA or here why we are pushing the 
dependency down.
   
   It is not clear to me either :(
   Having the dependencies in the parent pom results in having all the shaded 
dependencies erronously added to the client artifact descriptor.
   Moving the dependecies one level down results in an artifact with no 
dependencies (the expected behaviour)
   
   Not the first and not the last maven bug (or undocumented/unexplained 
behaviour) that we see. 
   Unfortunately, we didn't catch this one until after 5.1.0 was released.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to