[
https://issues.apache.org/jira/browse/PHOENIX-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283554#comment-17283554
]
ASF GitHub Bot commented on PHOENIX-6380:
-----------------------------------------
stoty commented on pull request #1141:
URL: https://github.com/apache/phoenix/pull/1141#issuecomment-778061325
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 58s | master passed |
| +0 | hbaserecompile | 21m 25s | HBase recompiled. |
| +1 :green_heart: | compile | 0m 27s | master passed |
| +1 :green_heart: | javadoc | 0m 18s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 13s | the patch passed |
| +0 | hbaserecompile | 37m 8s | HBase recompiled. |
| +1 :green_heart: | compile | 0m 27s | the patch passed |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 0m 16s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 43s | phoenix-client-embedded in the
patch passed. |
| +0 :ok: | asflicense | 0m 14s | ASF License check generated no
output? |
| | | 50m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1141/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1141 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 4d4a6a1a899b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 63bb42c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1141/1/testReport/
|
| Max. process+thread count | 76 (vs. ulimit of 30000) |
| modules | C: phoenix-client-parent/phoenix-client-embedded U:
phoenix-client-parent/phoenix-client-embedded |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1141/1/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> phoenix-client-embedded depends on logging classes
> --------------------------------------------------
>
> Key: PHOENIX-6380
> URL: https://issues.apache.org/jira/browse/PHOENIX-6380
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: core
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> While we are excluding org.slf4j:slf4j-log4j12 from the embedded client, it
> is added to to dependency list instead.
> We should probably find a way not have those as a dependency.
> One possibility is excluding it from the phoenix-core dependency.
> We may also trun those into optional dependcies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
